mesh_channel: new oneshot channel implementation #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
reviewed
Jan 6, 2025
smalis-msft
reviewed
Jan 6, 2025
8 tasks
daprilik
reviewed
Jan 6, 2025
| #[derive(Debug)] | ||
| struct OneshotReceiverCore { | ||
| slot: Arc<Slot>, | ||
| port: Option<PortWithHandler<SlotHandler>>, |
There was a problem hiding this comment.
is there no way to squeeze the port into the slot itself, so local oneshot receivers don't have to pay the cost of this always-None field?
There was a problem hiding this comment.
A little too tricky for v1 due to our use of Arc. I'll add a comment to improve this later.
daprilik
previously approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Spent some time staring at this unsafe code as well... and yeah, much like the last PR, this all seems to check out. Much like #594, I'm happy to see this land as-is, and then follow up with some more unsafe CR from other folks.
daprilik
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a similar approach to #594 but for oneshot channels.
This reduces openvmm_hcl binary size by a few hundred KB, and it improves oneshot channel overhead by an unmeasured amount.