Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix error handling in build_support/setup_windows_cross.sh #410

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

benhillis
Copy link
Member

@benhillis benhillis commented Nov 27, 2024

This resolves the error handling in the setup_windows_cross.sh script which was referencing a deleted file.

@benhillis benhillis requested a review from a team as a code owner November 27, 2024 23:05
Copy link
Contributor

@daprilik daprilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just inline this function into setup_windows_cross.sh

@daprilik daprilik self-requested a review November 27, 2024 23:29
Copy link
Contributor

@daprilik daprilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to approve. This def shouldn't be its own file anymore

@benhillis
Copy link
Member Author

Lets just inline this function into setup_windows_cross.sh

Ok will do.

@benhillis benhillis changed the title Add missing error.sh script CI: Fix error handling in build_support/setup_windows_cross.sh Nov 28, 2024
@benhillis benhillis force-pushed the user/benhill/error_sh branch from 3ea1b41 to 691e491 Compare November 28, 2024 17:57
@benhillis benhillis enabled auto-merge (squash) November 28, 2024 18:00
@benhillis benhillis merged commit a177fe6 into microsoft:main Nov 28, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants