Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sparse_mmap: remove C code and add SAFETY comments #117

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

sparse_mmap: remove C code and add SAFETY comments #117

wants to merge 1 commit into from

Commits on Oct 17, 2024

  1. sparse_mmap: remove C code and add SAFETY comments 

    To a certain extent this change "hardcodes"/"emulates"
`setjmp` and `longjmp` (not their `sig` counterparts though).
These might be tightly intergrated with the system C library
making this code brittle. Need to look more into that.

The unit-test do pass on Linux and macOS, but sometimes the
Windows guest wouldn't boot in the integration tests (tested
only in nested so far). I might be cargo-culting something.
    @romank-msft
    romank-msft committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d358a9e View commit details
    Browse the repository at this point in the history