-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contrib ops for TRT plugins: EfficientNMS and Pyramid ROI Align #9486
Contrib ops for TRT plugins: EfficientNMS and Pyramid ROI Align #9486
Conversation
/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline |
/azp run MacOS NoContribops CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows WebAssembly CI Pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline |
Azure Pipelines successfully started running 8 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 8 pipeline(s). |
seems related - #8461 |
@ytaous : This PR also needs a small change in the onnx-tensorrt dependency (the NVIDIA ONNX parser), specifically this line: This change was published on onnx-tensorrt with the TRT 8.2 GA release. Should I update the git submodule commit for that dependency as part of this PR already? Otherwise, merging of this PR should probably wait until ORT with TensorRT v8.2 support is fully merged first. |
@jywu-msft - comments/feedback? |
@stevenlix , please review. is this up to date based on latest iteration? |
Hello again, I just noticed that the In that case, this PR should now be ready to merge (after any necessary reviews and such of course). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We see TRT dll issues in windows when use crop and resize plugin. The issue is under investigation and will be addressed in separate PR in the future.
/azp run onnxruntime-binary-size-checks-ci-pipeline |
Azure Pipelines successfully started running 1 pipeline(s). |
Description:
Registers two new contrib ops for TensorRT plugins: EfficientNMS, PyramidROIAlign and multilevelCropAndResizePlugin, which are common operations in object detection networks.
Motivation and Context