Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice elimination rewrite rule; re-implementation of identity elimination using new Graph API #87

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Slice elimination rewrite rule; re-implementation of identity elimination using new Graph API #87

merged 3 commits into from
Jan 31, 2019

Conversation

kkaranasos
Copy link
Contributor

Rewrite rule that eliminates slice operators when they are redundant (i.e., when they preserve the whole input).
Re-implementation of the identity elimination rule using the new Graph API.

@kkaranasos kkaranasos requested a review from a team as a code owner December 4, 2018 07:34
linkerzhang
linkerzhang suggested changes Dec 5, 2018
View reviewed changes
include/onnxruntime/core/graph/rewrite_rule.h Outdated Show resolved Hide resolved
include/onnxruntime/core/graph/rewrite_rule.h Outdated Show resolved Hide resolved
include/onnxruntime/core/graph/rewrite_rule.h Outdated Show resolved Hide resolved
linkerzhang
linkerzhang approved these changes Dec 5, 2018
View reviewed changes
onnxruntime/core/graph/identity_elimination.cc Outdated Show resolved Hide resolved
onnxruntime/core/graph/slice_elimination.cc Outdated Show resolved Hide resolved
linkerzhang
linkerzhang previously requested changes Dec 5, 2018
View reviewed changes
onnxruntime/core/graph/identity_elimination.cc Outdated Show resolved Hide resolved
@kkaranasos kkaranasos mentioned this pull request Dec 21, 2018
Merged
@kkaranasos kkaranasos force-pushed the kkaranasos/slice-elimination branch from c7b494b to 79fed4d Compare December 22, 2018 03:08
@kkaranasos kkaranasos force-pushed the kkaranasos/slice-elimination branch from 39547ba to 0a905ae Compare January 29, 2019 03:03
@kkaranasos kkaranasos force-pushed the kkaranasos/slice-elimination branch from 0a905ae to fa8fcc2 Compare January 30, 2019 01:19
@linkerzhang linkerzhang dismissed their stale review January 30, 2019 23:07

not blocking the merge.

@kkaranasos kkaranasos merged commit c76725d into master Jan 31, 2019
@kkaranasos kkaranasos deleted the kkaranasos/slice-elimination branch January 31, 2019 00:21
@JonathanSum JonathanSum mentioned this pull request Mar 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weixingzhang weixingzhang weixingzhang approved these changes

@linkerzhang linkerzhang linkerzhang left review comments

@yuanbyu yuanbyu Awaiting requested review from yuanbyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkaranasos @linkerzhang @weixingzhang