Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TRT provider option configuration for C# (updated version) #7808
Enable TRT provider option configuration for C# (updated version) #7808
Changes from 1 commit
7c2d4c6
1921ec4
9ec0f35
6ac01ca
de6cb01
c80a02a
a2b8984
681c319
a67fcf3
ace27d2
12b7cdc
a763a64
557724b
b628bf5
9677dfc
3e9d013
d8c18aa
69d37e8
d40122b
b456e6c
2a87b40
99774ae
9a0b07c
96851de
30cc55c
2576645
497550d
748cb95
1f815e4
0a173c4
ae45fe8
1126559
e6953e8
5fff868
7a5f903
5e3f600
3ee5b20
b312090
1f6280e
c48c9ba
41a8dee
3649fa9
2ca2a19
a2456af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these the implementations of the C API functions?
if so, should we ensure that exceptions do not propagate outside of these calls (e.g., with API_IMPL_BEGIN/API_IMPL_END)? and why are these C API functions defined in provider_bridge_ort.cc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering what kind of functions should be in the C API?
For these four functions, it's related to TRT EP functionality. So I think I will move the definition of them out of C API and define/implemented them in provider_bridge_ort.cc and tensorrt_provider_factor.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, looks like you had to go back & forth with these functions & the C API, but this is good. The only issue I see is if they need API_IMPL_BEGIN/API_IMPL_END like Edward mentions above, just to be sure we don't throw any exceptions through them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, API_IMPL_BEGIN/API_IMPL_END is needed. Just added them.