fix for possible incremental build breaks. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavsharma
approved these changes
Nov 29, 2018
…o jywu/incr_fixup
souptc
pushed a commit
that referenced
this pull request
Dec 17, 2018
Changes to facilitate Code Coverage build * Put all unit tests in same project as code coverage is at the exe level * so splitting unit tests by component leads to artificially low numbers * default to all-in-one but left capability to split if people want it for local development * Add Google Test adapter pieces so unit tests can be run using CI components * Add some more exclusions to code coverage settings * Setup logging test to handle default logger coming from TestEnvironment * Previously the unit tests for Common didn't setup a default logger so there was no clash * Update build.py to split running tests from onnx tests * As the code coverage will run as part of 'normal' VS unit test execution, the build script doesn't need to run them * Tweak a few tests * Was just changing code coverage numbers to see how that showed up in builds I have setup a nightly build on the 'Hosted VS2017' queue that I'll enable once this is checked in. Once the AI-Win* queues are updated to VS2017 Enterprise I'll enable code coverage on those builds and eventually delete the extra Hosted VS2017 build. Related work items: #55
tmccrmck
pushed a commit
to tmccrmck/onnxruntime
that referenced
this pull request
Aug 28, 2019
Add shortcut endpoint for predict request and health endpoint for orchestration systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup for reported incremental build break issue.