Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #31, add option numpy_version, skip_keras_test to the parser of build.py, add flag PRIVATE for the python bindings #544

Merged
merged 4 commits into from
Mar 7, 2019
Merged

Fixes #31, add option numpy_version, skip_keras_test to the parser of build.py, add flag PRIVATE for the python bindings #544

merged 4 commits into from
Mar 7, 2019

Conversation

xadupre
Copy link
Member

@xadupre xadupre commented Mar 5, 2019 •
edited
Loading

  • add option numpy_version to build against the installed numpy version and not 1.15.0 (hardcoded version number)
  • add option skip_keras_test to skip keras test even if keras is installed (still enabled by default)
  • disable unnecessary warnings about ubuntu
  • enable option PRIVATE for the compilation of the Python bindings, that the settings recommended on pybind11 documentation (with this flag, the compilation works on a python compiled without --enable-shared enabled, this flag is needed to let a package run the Python interpreter from within, which is not necessary right now)
  • test on debian 9

@xadupre xadupre requested a review from a team as a code owner March 5, 2019 19:42
@xadupre xadupre changed the title [WIP] compilation on debian Fixes #31, add option numpy_version, skip_keras_test to the parser of build.py, add flag PRIVATE for the python bindings Mar 6, 2019
snnn
snnn approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, I would prefer to move the package installation code to the pipeline yaml files.

@xadupre xadupre merged commit b4ffcf8 into master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snnn snnn snnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xadupre @snnn @sdpython