Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webgpu] fix compiling error #23139

Merged
merged 3 commits into from
Dec 20, 2024
Merged

[webgpu] fix compiling error #23139

merged 3 commits into from
Dec 20, 2024

Conversation

xhcao
Copy link
Contributor

@xhcao xhcao commented Dec 18, 2024

Description

Motivation and Context

@xhcao
Copy link
Contributor Author

xhcao commented Dec 18, 2024

@fs-eire @guschmue Please take a look, dawn removed all uses of const char* callbacks, https://dawn-review.googlesource.com/c/dawn/+/210437
@jchen10 @hujiajie

@fs-eire
Copy link
Contributor

fs-eire commented Dec 18, 2024

/azp run Windows GPU WebGPU CI Pipeline, MacOS CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fs-eire
Copy link
Contributor

fs-eire commented Dec 18, 2024

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Dec 18, 2024

/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,orttraining-linux-gpu-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline,iOS CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Dec 18, 2024

/azp run ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

Copy link

Azure Pipelines successfully started running 9 pipeline(s).

Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@fs-eire
Copy link
Contributor

fs-eire commented Dec 18, 2024

I am surprised that existing CI pipelines didn't catch the build error. @xhcao what is your build environment?

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Dec 19, 2024
@xhcao
Copy link
Contributor Author

xhcao commented Dec 20, 2024

I am surprised that existing CI pipelines didn't catch the build error. @xhcao what is your build environment?

I cannot produce this issue if I upgrade the Visual studio and the version VC is 14.42.34433.
I produced this issue on Debug build and old visual studio.

@fs-eire
Copy link
Contributor

fs-eire commented Dec 20, 2024

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Dec 20, 2024

/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Dec 20, 2024

/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline

Copy link

Azure Pipelines successfully started running 7 pipeline(s).

Copy link

Azure Pipelines successfully started running 8 pipeline(s).

Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@fs-eire
Copy link
Contributor

fs-eire commented Dec 20, 2024

/azp run Windows GPU WebGPU CI Pipeline

Copy link

No pipelines are associated with this pull request.

@fs-eire fs-eire merged commit 29bccad into microsoft:main Dec 20, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants