Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js/webgpu] fix Conv2DMatMul shader's out-of-bound read #23085

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Dec 11, 2024

Description

Fix a bug caused by potential out-of-bound reads of W in the Conv2DMatMul shader.

Motivation and Context

Fixes #22983

@fs-eire
Copy link
Contributor Author

fs-eire commented Dec 11, 2024

@qjia7 PTAL

Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fs-eire fs-eire merged commit 01539ee into main Dec 12, 2024
62 checks passed
@fs-eire fs-eire deleted the fs-eire/conv2d-mm-fix-read-out-of-bound branch December 12, 2024 19:33
guschmue pushed a commit that referenced this pull request Dec 20, 2024
### Description
<!-- Describe your changes. -->

Fix a bug caused by potential out-of-bound reads of `W` in the
Conv2DMatMul shader.

### Motivation and Context

Fixes #22983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web] Stable Diffusion Inpainting FP16 UNET outputs NANs
3 participants