[CPU EP] optimize qlinearsoftmax #22686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wejoncy
force-pushed
the
jicwen/optimize_qsoftmax
branch
from
32a8c8c to
6df1676
Compare
wejoncy
force-pushed
the
jicwen/optimize_qsoftmax
branch
from
4233379 to
f7d97e1
Compare
yihonglyu
reviewed
Nov 4, 2024
yihonglyu
reviewed
Nov 5, 2024
yihonglyu
reviewed
Nov 5, 2024
Could you also include cycles for Softmax using the existing microbenchmark or by adding a new one?" |
What do you mean by " include cycles for Softmax" ? Mlas BENCHMARK_CAPTURE should have timer function to estimate the time cost. |
Given that the unoptimized QLinearSoftmax is slower than Softmax, I wanted to include the Softmax number as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
X86-64
AVX2/AVX512
ARM
Not implemented
Improves
Motivation and Context