Adding DML to python cuda package #22606
Merged
+70
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r packaging DML EP in the same ORT GPU pkg.
snnn
reviewed
Oct 25, 2024
tools/ci_build/github/azure-pipelines/stages/py-gpu-packaging-stage.yml
Outdated
Show resolved
Hide resolved
snnn
reviewed
Oct 25, 2024
tools/ci_build/github/azure-pipelines/stages/py-gpu-packaging-stage.yml
Outdated
Show resolved
Hide resolved
jchen351
changed the title
snnn
reviewed
Oct 25, 2024
tools/ci_build/github/azure-pipelines/stages/py-gpu-packaging-stage.yml
Outdated
Show resolved
Hide resolved
# Conflicts: # tools/ci_build/github/azure-pipelines/stages/py-win-gpu-stage.yml
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # tools/ci_build/github/azure-pipelines/stages/py-win-gpu-stage.yml
|
Please run the pipelines you modified. |
|
Previously we saw after this change "Python-CUDA-Packaging-Pipeline" always timed out. Was the issue resolved or not? |
snnn
approved these changes
Dec 4, 2024
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new parameter --devices for the
create_backend_testfunction inonnxruntime/test/python/onnx_backend_test_series.pyto allow specifying the devices to test.Because both tests and supported EPs are in exclusion lists. We only run tests that is compatible for all devices from args.devices, and EPs that are defined.
In case when only CUDA or DML EP are enabled, Python packaging tests will only run the tests that is compatible with the enabled EP, and only the enabled EP and CPU EP will be enabled. CPU EP is always enabled.
In case when both CUDA and DML EP are enabled. Python packaging tests will only run the tests that is compatible with both CUDA and DML, and only CPU EP will be enabled (CUDA and DML EPs are mutually exclusive). CPU EP is always enabled.
Motivation and Context