Remove ort_mutex.h and nsync #22485
Closed
Remove ort_mutex.h and nsync #22485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
force-pushed
the
snnn/remove_lock
branch
from
9a43c2c to
bf8f057
Compare
snnn
force-pushed
the
snnn/remove_lock
branch
from
d8f038f to
ac3fc9b
Compare
This reverts commit 94aa21c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #3000 , I added a custom implementation of std::mutex . It was mainly because at that time std::mutex's default constructor was not trivial on Windows. If you had such a mutex as a global var, it could not be initialized at compile time. Then VC++ team fixed this issue. Therefore we don't need this custom implementation anymore.
This PR also removes nsync. I ran several models tests on Linux. I didn't see any perf difference.
This PR also reverts PR #21005 , which is no longer needed since conda has updated its msvc runtime DLL.
This PR unblocks #22173 and resolves #22092