-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Abseil OStringStream in WebGPU EP string concat #22241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…webgpu-ep-use-absl-oss
…webgpu-ep-use-absl-oss
…webgpu-ep-use-absl-oss
skottmckay
reviewed
Sep 30, 2024
Comment on lines
+31
to
+35
template <typename T, typename... Args> | ||
inline void OStringStreamAppendImpl(std::ostream& ss, const T& t, const Args&... args) noexcept { | ||
OStringStreamAppendImpl(ss, t); | ||
OStringStreamAppendImpl(ss, args...); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add something like this to decay const char[]
to const char*
? It saves significant binary size to do so.
onnxruntime/include/onnxruntime/core/common/make_string.h
Lines 91 to 103 in 1bda91f
// We need to update the types from the MakeString template instantiation to decay any char[n] to char*. | |
// e.g. MakeString("in", "out") goes from MakeString<char[2], char[3]> to MakeStringImpl<char*, char*> | |
// so that MakeString("out", "in") will also match MakeStringImpl<char*, char*> instead of requiring | |
// MakeStringImpl<char[3], char[2]>. | |
// | |
// We have to do the type processing before any actual work, so this function purely implements the type processing. | |
// If we do not do it this way we do not get the full binary size reduction. | |
// | |
// See https://stackoverflow.com/a/29418212/684911 for overall details of the approach, but note it does not cover | |
// the need to do the type processing as a separate step. | |
return detail::MakeStringImpl(detail::if_char_array_make_ptr_t<Args const&>(args)...); | |
} |
skottmckay
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use Abseil OStringStream in WebGPU EP string concat.
Allows multiple calls to shader_helper.MainFunctionBody()