Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Abseil OStringStream in WebGPU EP string concat #22241

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Sep 27, 2024

Description

use Abseil OStringStream in WebGPU EP string concat.

Allows multiple calls to shader_helper.MainFunctionBody()

Comment on lines +31 to +35
template <typename T, typename... Args>
inline void OStringStreamAppendImpl(std::ostream& ss, const T& t, const Args&... args) noexcept {
OStringStreamAppendImpl(ss, t);
OStringStreamAppendImpl(ss, args...);
}
Copy link
Contributor

@skottmckay skottmckay Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add something like this to decay const char[] to const char*? It saves significant binary size to do so.

// We need to update the types from the MakeString template instantiation to decay any char[n] to char*.
// e.g. MakeString("in", "out") goes from MakeString<char[2], char[3]> to MakeStringImpl<char*, char*>
// so that MakeString("out", "in") will also match MakeStringImpl<char*, char*> instead of requiring
// MakeStringImpl<char[3], char[2]>.
//
// We have to do the type processing before any actual work, so this function purely implements the type processing.
// If we do not do it this way we do not get the full binary size reduction.
//
// See https://stackoverflow.com/a/29418212/684911 for overall details of the approach, but note it does not cover
// the need to do the type processing as a separate step.
return detail::MakeStringImpl(detail::if_char_array_make_ptr_t<Args const&>(args)...);
}

@fs-eire fs-eire merged commit c1ae1fd into fs-eire/webgpu-ep Sep 30, 2024
40 of 41 checks passed
@fs-eire fs-eire deleted the fs-eire/webgpu-ep-use-absl-oss branch September 30, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants