Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove neural-speed #22236

Merged
merged 2 commits into from
Oct 1, 2024
Merged

remove neural-speed #22236

merged 2 commits into from
Oct 1, 2024

Conversation

yufenglee
Copy link
Member

Description

NS is not developed anymore and ORT doesn't use it for int4 inference either. Remove it to clean up the code

Motivation and Context

@yufenglee yufenglee requested a review from a team as a code owner September 26, 2024 21:20
@yufenglee yufenglee requested a review from a team September 26, 2024 21:20
snnn
snnn previously approved these changes Sep 26, 2024
@snnn snnn dismissed their stale review September 26, 2024 22:55

Please run clang-format on onnxruntime/test/mlas/bench/bench_sqnbitgemm.cpp

@snnn
Copy link
Member

snnn commented Sep 26, 2024

Please also run https://github.com/microsoft/onnxruntime/blob/main/cgmanifests/generate_cgmanifest.py, so that this library will be removed from the cgmanifest json files.

@yufenglee yufenglee requested a review from a team as a code owner September 27, 2024 00:01
snnn
snnn previously approved these changes Sep 27, 2024
@snnn snnn dismissed their stale review September 27, 2024 15:45

Added one comment

@pranavsharma pranavsharma merged commit 96e9c99 into main Oct 1, 2024
81 checks passed
@pranavsharma pranavsharma deleted the yufeng/ns branch October 1, 2024 16:50
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this pull request Nov 19, 2024
### Description
<!-- Describe your changes. -->
NS is not developed anymore and ORT doesn't use it for int4 inference
either. Remove it to clean up the code


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants