Update gradle version to 8.7 #22206
Draft
Update gradle version to 8.7 #22206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchen351
commented
Sep 24, 2024
java/gradlew.bat
Outdated
There was a problem hiding this comment.
Changes from this file is generated by ./gradlew wrapper --gradle-version=8.10.2 --distribution-type=bin
|
All changes from Changes from |
jchen351
changed the title
skottmckay
reviewed
Sep 26, 2024
| @@ -13,7 +13,7 @@ | |||
| #Tue Jan 26 17:36:02 PST 2021 | |||
| android.enableJetifier=true | |||
| android.useAndroidX=true | |||
| OnnxruntimeModule_buildToolsVersion=29.0.2 | |||
| OnnxruntimeModule_buildToolsVersion=30.0.3 | |||
There was a problem hiding this comment.
So should we specify the 34+ build tools here if it's going to be forced to that anyway?
There was a problem hiding this comment.
For this MR, I am only updating the 'com.android.tools.build:gradle:7.4.2' insead of the 'com.android.tools.build:gradle:8.5'. So, the required build tool version is only 30.0.3.
There was a problem hiding this comment.
In a separated PR when the com.android.tools.build:gradle is 8.5+ the required version of Android SDK Build Tools then become 34.0.0
tools/ci_build/github/azure-pipelines/templates/android-java-api-aar.yml
Outdated
Show resolved
Hide resolved
DEFAULT_ANDROID_TARGET_SDK_VER = 33
// implementation "com.microsoft.onnxruntime:onnxruntime-android:latest.integration@aar"
….integration@aar" revert back to
jchen351
added a commit
that referenced
this pull request
Nov 15, 2024
…#22771) ### Description This change is to update the Gradle version within java project to 8.7, it also upgrades the JAVA to 17. Gradle version from react-native was also updated to 7.5 to make it compatible with changes from the Java directory. However, the target java version remains the same. Java version from these will be upgraded in a separated PR. This is spited from #22206 ### Motivation and Context This is the first step to upgrade the react native version.
# Conflicts: # java/build-android.gradle # java/src/test/android/app/build.gradle # java/src/test/android/app/src/main/AndroidManifest.xml # js/react_native/android/gradle.properties # js/react_native/android/gradle/wrapper/gradle-wrapper.jar # js/react_native/android/gradle/wrapper/gradle-wrapper.properties # js/react_native/android/gradlew # js/react_native/android/gradlew.bat # tools/ci_build/github/android/build_aar_package.py # tools/ci_build/github/android/default_full_aar_build_settings.json
# Conflicts: # js/react_native/android/gradle.properties # js/react_native/e2e/android/build.gradle # js/react_native/e2e/android/gradle/wrapper/gradle-wrapper.properties # tools/ci_build/github/android/training_full_aar_build_settings.json # tools/ci_build/github/js/react_native_e2e_full_aar_build_settings.json
# Conflicts: # js/react_native/e2e/android/gradle.properties
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
120
to
122
| "-no-audio", | ||
| "-no-bt", # No Bluetooth | ||
| "-no-boot-anim", |
There was a problem hiding this comment.
Suggested change
| "-no-audio", | |
| "-no-bt", # No Bluetooth | |
| "-no-boot-anim", | |
| "-no-audio", | |
| "-no-bt", # No Bluetooth | |
| "-no-boot-anim", |
ishwar-raut1
pushed a commit
to ishwar-raut1/onnxruntime
that referenced
this pull request
Nov 19, 2024
…microsoft#22771) ### Description This change is to update the Gradle version within java project to 8.7, it also upgrades the JAVA to 17. Gradle version from react-native was also updated to 7.5 to make it compatible with changes from the Java directory. However, the target java version remains the same. Java version from these will be upgraded in a separated PR. This is spited from microsoft#22206 ### Motivation and Context This is the first step to upgrade the react native version.
guschmue
pushed a commit
that referenced
this pull request
Dec 2, 2024
…#22771) ### Description This change is to update the Gradle version within java project to 8.7, it also upgrades the JAVA to 17. Gradle version from react-native was also updated to 7.5 to make it compatible with changes from the Java directory. However, the target java version remains the same. Java version from these will be upgraded in a separated PR. This is spited from #22206 ### Motivation and Context This is the first step to upgrade the react native version.
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
…microsoft#22771) ### Description This change is to update the Gradle version within java project to 8.7, it also upgrades the JAVA to 17. Gradle version from react-native was also updated to 7.5 to make it compatible with changes from the Java directory. However, the target java version remains the same. Java version from these will be upgraded in a separated PR. This is spited from microsoft#22206 ### Motivation and Context This is the first step to upgrade the react native version.
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
…microsoft#22771) ### Description This change is to update the Gradle version within java project to 8.7, it also upgrades the JAVA to 17. Gradle version from react-native was also updated to 7.5 to make it compatible with changes from the Java directory. However, the target java version remains the same. Java version from these will be upgraded in a separated PR. This is spited from microsoft#22206 ### Motivation and Context This is the first step to upgrade the react native version.
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
…microsoft#22771) ### Description This change is to update the Gradle version within java project to 8.7, it also upgrades the JAVA to 17. Gradle version from react-native was also updated to 7.5 to make it compatible with changes from the Java directory. However, the target java version remains the same. Java version from these will be upgraded in a separated PR. This is spited from microsoft#22206 ### Motivation and Context This is the first step to upgrade the react native version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the gradle version from andriod projects to 8.7
And Android gradle build tool to version 7.4.2 across all of the ORT project.
Motivation and Context
Current versions of gradle are inconsistent and outdated to support newer version of plugins such as react-native.
Inconsistent versioning makes upgrading a lot more challenging.
Current issue
child-process:SPAWN_STDOUT INSTRUMENTATION_RESULT: shortMsg=Process crashed.<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>latest.integrationdoes work on "com.microsoft.onnxruntime:onnxruntime-android:latest.integration@aar" anymoreAB#50089