Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN EP] Create MLGraphBuilder for every model builder #21514

Merged
merged 2 commits into from
Aug 1, 2024
Merged

[WebNN EP] Create MLGraphBuilder for every model builder #21514

merged 2 commits into from
Aug 1, 2024

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Jul 26, 2024 •
edited
Loading

Currently WebNN spec only allows MLGraphBuilder.build() to be called once, we need to create new builder for every subgraph in WebNN EP.

Spec change: webmachinelearning/webnn#717

@Honry
Copy link
Contributor Author

Honry commented Jul 26, 2024

@fdwr, @guschmue, @huningxin, PTAL, thanks!

@Honry Honry mentioned this pull request Jul 26, 2024
Closed
huningxin
huningxin approved these changes Jul 26, 2024
View reviewed changes
Copy link

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment.

BTW, you may want to refer to the spec change PR: webmachinelearning/webnn#717

onnxruntime/core/providers/webnn/builders/model_builder.h Outdated Show resolved Hide resolved
@Honry Honry force-pushed the dont-reuse-builder branch from a4a76b3 to 5a7c92b Compare July 26, 2024 05:31
@ibelem ibelem mentioned this pull request Jul 26, 2024
Merged
huningxin
huningxin approved these changes Jul 26, 2024
View reviewed changes
Copy link

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fdwr
fdwr approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr fdwr added the ep:WebNN WebNN execution provider label Jul 26, 2024
@fdwr
Copy link
Contributor

fdwr commented Jul 26, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Jul 26, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Jul 26, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Jul 30, 2024

/azp run Windows GPU TensorRT CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Honry Honry force-pushed the dont-reuse-builder branch from 5a7c92b to c7b3eae Compare July 30, 2024 06:47
@fdwr
Copy link
Contributor

fdwr commented Jul 30, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Jul 30, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Jul 30, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Jul 31, 2024 •
edited
Loading

@Honry Merge with your most recent change for the Web CI failures?

Honry added 2 commits August 1, 2024 08:19
@Honry
[WebNN EP] Create MLGraphBuilder for every model builder
74c63bb 
Currently WebNN spec only allows MLGraphBuilder.build() to be called
once, we need to create builder for every subgraph in WebNN EP.
@Honry
Release WebNN builder after graph built
57dbebb
@Honry Honry force-pushed the dont-reuse-builder branch from c7b3eae to 57dbebb Compare August 1, 2024 00:23
@Honry
Copy link
Contributor Author

Honry commented Aug 1, 2024

@Honry Merge with your most recent change for the Web CI failures?

Sure, done, pls. help retrigger the CI. Thanks!

@fdwr
Copy link
Contributor

fdwr commented Aug 1, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Aug 1, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Aug 1, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@fdwr fdwr merged commit 8c2ee7b into microsoft:main Aug 1, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

@huningxin huningxin huningxin approved these changes

Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honry @fdwr @huningxin