Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ck to use ck_tile #21030

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Update ck to use ck_tile #21030

merged 9 commits into from
Jun 19, 2024

Conversation

cloudhan
Copy link
Contributor

No description provided.

@cloudhan cloudhan requested review from a team as code owners June 13, 2024 07:15
@cloudhan cloudhan requested review from tianleiwu and mszhanyi June 13, 2024 07:15
@cloudhan cloudhan mentioned this pull request Jun 13, 2024
Merged
3 tasks
@cloudhan cloudhan force-pushed the guangyunhan/update-ck-tile branch from a0e3deb to 3ddae25 Compare June 14, 2024 07:32
tianleiwu
tianleiwu reviewed Jun 14, 2024
View reviewed changes
cmake/CMakeLists.txt Outdated Show resolved Hide resolved
@tianleiwu
Copy link
Contributor

There is build error:
https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1408061&view=logs&j=de55e6b9-e644-5941-5c9e-9db93f25fbbe&t=b93ed647-1ade-5719-e8ee-b4d0a50e0589&l=3839

@cloudhan
Copy link
Contributor Author

There is build error: https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1408061&view=logs&j=de55e6b9-e644-5941-5c9e-9db93f25fbbe&t=b93ed647-1ade-5719-e8ee-b4d0a50e0589&l=3839

The compiler crashed for unknown reason.

@cloudhan
Copy link
Contributor Author

I can reproduce the crash with a random rocm 6.0.0 docker image. local development with 6.0.3 compiles fine.

@cloudhan cloudhan force-pushed the guangyunhan/update-ck-tile branch 2 times, most recently from 2a778f8 to 196914d Compare June 17, 2024 10:49
@cloudhan
Copy link
Contributor Author

@snnn @mszhanyi some pipeline failed with ssl/cert related issue as follows

ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1131)

any idea on how to solve?

@snnn
Copy link
Member

snnn commented Jun 18, 2024

Run it again. It has been fixed.

@cloudhan cloudhan force-pushed the guangyunhan/update-ck-tile branch from 196914d to 8882ec3 Compare June 18, 2024 04:14
snnn
snnn previously approved these changes Jun 18, 2024
View reviewed changes
@cloudhan cloudhan requested review from pranavsharma and removed request for mszhanyi June 19, 2024 05:40
pranavsharma
pranavsharma approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@pranavsharma pranavsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewing for admin

@cloudhan cloudhan merged commit ddd4ce3 into main Jun 19, 2024
141 of 148 checks passed
@cloudhan cloudhan deleted the guangyunhan/update-ck-tile branch June 19, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianleiwu tianleiwu tianleiwu left review comments

@pranavsharma pranavsharma pranavsharma approved these changes

@snnn snnn snnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cloudhan @tianleiwu @snnn @pranavsharma