Implement numpy array over CPU OrtValues on return values #20539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuslepukhin
force-pushed
the
yuslepukhin/numpy_over_ortvalue
branch
from
3429155 to
5ec0907
Compare
we preserve the original behaviour. Adjust comments. Reserve space for py::list.
edgchen1
reviewed
May 3, 2024
baijumeswani
previously approved these changes
May 6, 2024
edgchen1
reviewed
May 6, 2024
edgchen1
approved these changes
May 7, 2024
edgchen1
previously approved these changes
May 7, 2024
edgchen1
reviewed
May 7, 2024
edgchen1
approved these changes
May 7, 2024
poweiw
pushed a commit
to poweiw/onnxruntime
that referenced
this pull request
Jun 25, 2024
…20539) ### Description Create numpy arrays based on the native buffers of returned OrtValues. Hold on to the OrtValue until the numpy array is garbage collected. ### Motivation and Context This saves cpu on tensor copies and addresses customer concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create numpy arrays based on the native buffers of returned OrtValues.
Hold on to the OrtValue until the numpy array is garbage collected.
Motivation and Context
This saves cpu on tensor copies and addresses customer concerns.