Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/mookerem/arm64x update #20536

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

moyo1997
Copy link
Contributor

@moyo1997 moyo1997 commented May 1, 2024

Made some changes to the arm64x.cmake script to:

  • handle edge case
  • Enable Projects that include onnxruntime as submodule and build it, to be able to build as x without causing onnxruntime build_as_x to fail.

@snnn snnn added the platform:windows issues related to the Windows platform label May 1, 2024
@jywu-msft
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@jywu-msft
Copy link
Member

/azp run Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Android CI Pipeline, Linux OpenVINO CI Pipeline

Copy link

Azure Pipelines successfully started running 10 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@snnn snnn merged commit aff04ba into microsoft:main May 7, 2024
77 of 78 checks passed
@jywu-msft
Copy link
Member

@moyo1997 , do you know if arm64ec/arm64x works with python modules built as arm64ec?
onnxruntime project has an onnxruntime_pybind11_state target, which builds onnxruntime_pybind11_state.pyd that can be loaded by python. I am trying to build onnxruntime_pybind11_state.pyd as arm64ec so that it can be loaded by a python process running in x64 emulation mode. Seems to crash though. Any ideas?

Exception thrown at 0x00007FFA223BCE58 in python.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x00000074D09EC458.
Unhandled exception at 0x00007FF934586328 (onnxruntime_pybind11_state.pyd) in python.exe: 0xC000026F: An internal error occurred in the Win32 x86 emulation subsystem.

@moyo1997
Copy link
Contributor Author

moyo1997 commented May 7, 2024

@jywu-msft arm64ec I'm not familiar with Python modules. I'll message you with an alias you can reach out to for help here :)

poweiw pushed a commit to poweiw/onnxruntime that referenced this pull request Jun 25, 2024
Made some changes to the arm64x.cmake script to:
- handle edge case
- Enable Projects that include onnxruntime as submodule and build it, to
be able to build as x without causing onnxruntime build_as_x to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:windows issues related to the Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants