Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate stray vector and the contention it creates #20377

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

yuslepukhin
Copy link
Member

@yuslepukhin yuslepukhin commented Apr 18, 2024

Description

Unused vector allocating large memory chunk within a concurrent routine
creates heap contention and is eliminated.

Motivation and Context

This partially addresses #20373.

@yuslepukhin yuslepukhin marked this pull request as ready for review April 18, 2024 20:36
@yuslepukhin yuslepukhin requested a review from skottmckay April 18, 2024 20:51
Copy link
Contributor

@skottmckay skottmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yuslepukhin yuslepukhin merged commit 42b700d into main Apr 19, 2024
92 of 94 checks passed
@yuslepukhin yuslepukhin deleted the yuslepukhin/eliminate_redundant_allocation branch April 19, 2024 17:27
TedThemistokleous pushed a commit to TedThemistokleous/onnxruntime that referenced this pull request May 7, 2024
### Description
Unused vector allocating large memory chunk within a concurrent routine
creates heap contention and is eliminated.

### Motivation and Context
This partially addresses
microsoft#20373.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants