Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update trigger rules for js change #19881

Closed
wants to merge 3 commits into from
Closed

update trigger rules for js change #19881

wants to merge 3 commits into from

Conversation

mszhanyi
Copy link
Contributor

Description

Motivation and Context

PR #19735 should not tirgger so many other pipelines.

@mszhanyi mszhanyi requested a review from a team as a code owner March 13, 2024 06:09
@mszhanyi mszhanyi requested a review from fs-eire March 13, 2024 06:10
@mszhanyi
Copy link
Contributor Author

mszhanyi commented Mar 13, 2024

@fs-eire , please review skip-js.yml, other changes are generated by python set-trigger-rules.py

@fs-eire
Copy link
Contributor

fs-eire commented Mar 13, 2024

comparing to feature changes (eg. kernel implementation), folder js/common and onnxruntime/wasm is not commonly modified. #19735 is not a change that should be commonly make.

js/common may contains changes to JavaScript API, which potentially affects ONNX Runtime Node.js binding and ONNX Runtime for React Native. This is why we don't want to exclude it from the trigger list.

Adding onnxruntime/wasm to the ignore list is OK. This folder should only affect WebAssembly build, which only used in web. please use this folder instead of the specific file

@mszhanyi
Copy link
Contributor Author

comparing to feature changes (eg. kernel implementation), folder js/common and onnxruntime/wasm is not commonly modified. #19735 is not a change that should be commonly make.

js/common may contains changes to JavaScript API, which potentially affects ONNX Runtime Node.js binding and ONNX Runtime for React Native. This is why we don't want to exclude it from the trigger list.

Adding onnxruntime/wasm to the ignore list is OK. This folder should only affect WebAssembly build, which only used in web. please use this folder instead of the specific file

OK, I could close the PR. If you want to exclude some pipelines, you could update skip-js.yml and python set-trigger-rules.py

@mszhanyi mszhanyi closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants