Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN] Enable npm unit tests #18486

Merged
merged 3 commits into from
Jan 9, 2024
Merged

[WebNN] Enable npm unit tests #18486

merged 3 commits into from
Jan 9, 2024

Conversation

zesongw
Copy link
Contributor

@zesongw zesongw commented Nov 17, 2023

Description

  • Support more test cases for WebNN EP in suite-test-list.jsonc
  • Add DISABLE_WEBNN flag in build.ts as preparing for WebNN EP release
  • Add test option: '--webnn-device-type' in test-runner-args-cli.ts to support running WebNN 'gpu' deviceType
  • Use Chrome Stable as default browser for WebNN testing to unblock the CI limitation.

[WebNN] Enable npm Unit tests
f1a43ac 
- Support more test cases for WebNN EP in suite-test-list.jsonc
- Add DISABLE_WEBNN flag in build.ts as preparing for WebNN EP release
- Add test option: '--webnn-device-type' in test-runner-args-cli.ts to support running WebNN 'gpu' deviceType
- Use Chrome Stable as default browser for WebNN testing to unblock the CI limitation.
@zesongw
Copy link
Contributor Author

zesongw commented Nov 17, 2023

@fdwr, @guschmue, PTAL, thanks!

@zesongw zesongw changed the title [WebNN] Enable npm Unit tests [WebNN] Enable npm unit tests Nov 17, 2023
@fdwr fdwr requested a review from guschmue November 18, 2023 00:47
fdwr
fdwr reviewed Nov 18, 2023
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except my one comment, everything looks reasonable to naive me, but Guenther could give more informative feedback than I can (or maybe Yulong). Thanks Zesong.

js/web/test/test-runner.ts Outdated Show resolved Hide resolved
fdwr
fdwr previously approved these changes Nov 23, 2023
View reviewed changes
@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

guschmue
guschmue previously approved these changes Nov 30, 2023
View reviewed changes
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue guschmue added the ep:WebNN WebNN execution provider label Nov 30, 2023
@guschmue
Copy link
Contributor

guschmue commented Dec 1, 2023

lint is nagging:
image

Fix several issues
5eb8973 
- Set default DISABLE_WEBNN to false, to allow to build WebNN EP locally.
- Update test suite for WebNN, comment tests with int32/int64 input.
- Fix lint error.
@zesongw zesongw dismissed stale reviews from guschmue and fdwr via 5eb8973 December 1, 2023 06:02
@guschmue
Copy link
Contributor

guschmue commented Dec 5, 2023

/azp run ONNX Runtime Web CI Pipeline

@guschmue
Copy link
Contributor

guschmue commented Dec 5, 2023

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

guschmue commented Dec 5, 2023

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue guschmue merged commit ad6dd0a into microsoft:main Jan 9, 2024
29 of 33 checks passed
@fs-eire fs-eire mentioned this pull request Jan 17, 2024
Closed
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
[WebNN] Enable npm unit tests (microsoft#18486)
c5d9e3a 
### Description
- Support more test cases for WebNN EP in suite-test-list.jsonc
- Add DISABLE_WEBNN flag in build.ts as preparing for WebNN EP release
- Add test option: '--webnn-device-type' in test-runner-args-cli.ts to
support running WebNN 'gpu' deviceType
- Use Chrome Stable as default browser for WebNN testing to unblock the
CI limitation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guschmue guschmue guschmue approved these changes

@fdwr fdwr fdwr left review comments

Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zesongw @guschmue @fdwr