Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js/webgpu] Change timestamp-query-in-passes to timestamp-query #18108

Merged
merged 2 commits into from
Oct 26, 2023
Merged

[js/webgpu] Change timestamp-query-in-passes to timestamp-query #18108

merged 2 commits into from
Oct 26, 2023

Conversation

gyagp
Copy link

@gyagp gyagp commented Oct 26, 2023

Timestamp-query has a broader support than timestamp-query-in-passes on all the platforms, including macOS.
Note that to enable timestamp-query, you still need to add switch "--enable-dawn-features=allow_unsafe_apis" to Chrome. By default, the lowest 16 bits are masked with 0 (at a granularity about 0.1ms) for privacy. To get the highest precision, you need to add another switch "--enable-webgpu-developer-features".

@gyagp
Copy link
Author

gyagp commented Oct 26, 2023

run web CI

@gyagp
Copy link
Author

gyagp commented Oct 26, 2023

@qjia7, please take a look.

Timestamp-query has a broader support than timestamp-query-in-passes on all the platforms, including macOS.
Note that to enable timestamp-query, you still need to add switch "--enable-dawn-features=allow_unsafe_apis" to Chrome. By default, the lowest 16 bits are masked with 0 (at a granularity about 0.1ms) for privacy. To get the highest precision, you need to add another switch "--enable-webgpu-developer-features".
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

js/web/lib/wasm/jsep/backend-webgpu.ts Show resolved Hide resolved
@gyagp
Copy link
Author

gyagp commented Oct 26, 2023

run web CI

@gyagp
Copy link
Author

gyagp commented Oct 26, 2023

@guschmue @satyajandhyala @fs-eire Please review this change, thanks!

@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Oct 26, 2023
@guschmue guschmue merged commit 52f4968 into microsoft:main Oct 26, 2023
36 of 38 checks passed
@gyagp gyagp deleted the tq branch October 27, 2023 02:39
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
…osoft#18108)

Timestamp-query has a broader support than timestamp-query-in-passes on
all the platforms, including macOS.
Note that to enable timestamp-query, you still need to add switch
"--enable-dawn-features=allow_unsafe_apis" to Chrome. By default, the
lowest 16 bits are masked with 0 (at a granularity about 0.1ms) for
privacy. To get the highest precision, you need to add another switch
"--enable-webgpu-developer-features".
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
…osoft#18108)

Timestamp-query has a broader support than timestamp-query-in-passes on
all the platforms, including macOS.
Note that to enable timestamp-query, you still need to add switch
"--enable-dawn-features=allow_unsafe_apis" to Chrome. By default, the
lowest 16 bits are masked with 0 (at a granularity about 0.1ms) for
privacy. To get the highest precision, you need to add another switch
"--enable-webgpu-developer-features".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants