Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MHA shape inference #18009

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

PatriceVignola
Copy link
Contributor

The previous shape inference never had the chance to infer the past_key and past_value outputs because we were returning early.

Copy link
Contributor

@tianleiwu tianleiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch of the issue!

@PatriceVignola PatriceVignola merged commit 61f1a16 into main Oct 18, 2023
@PatriceVignola PatriceVignola deleted the user/pavignol/fix-mha-shape-inference branch October 18, 2023 04:19
jchen351 pushed a commit that referenced this pull request Oct 18, 2023
The previous shape inference never had the chance to infer the past_key
and past_value outputs because we were returning early.
PatriceVignola added a commit that referenced this pull request Oct 26, 2023
The previous shape inference never had the chance to infer the past_key
and past_value outputs because we were returning early.
tianleiwu pushed a commit that referenced this pull request Oct 31, 2023
The previous shape inference never had the chance to infer the past_key
and past_value outputs because we were returning early.
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
The previous shape inference never had the chance to infer the past_key
and past_value outputs because we were returning early.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants