Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Add initializer to model in AttentionMask directly #17719

Merged

Conversation

jambayk
Copy link
Contributor

@jambayk jambayk commented Sep 27, 2023

Description

Fixes a bug introduced in PR #17427 where self.add_initializer is called in AttentionMask but the class doesn't have the given method.

This adds the initializer directly to self.model as before but with raw=False as intended in the PR above.

Motivation and Context

Fixes the bug described above.
The bug was caught while running Olive tests with the latest ort-nightly builds.
https://dev.azure.com/aiinfra/PublicPackages/_build/results?buildId=360918&view=logs&j=dbbdd4d8-ffd3-515a-31fd-659375dbdff8&t=13dad60e-7187-5e88-dbc0-776ed0850a3f&l=601

@jambayk
Copy link
Contributor Author

jambayk commented Sep 27, 2023

@tianleiwu FYI

@jambayk
Copy link
Contributor Author

jambayk commented Sep 27, 2023

@tianleiwu can you please trigger the required pipelines using /azp run commands?
I am not a contributor on the repository so they don’t get triggered automatically.

I don’t also have merge permissions for when the required checks are complete.
Thanks!

@baijumeswani
Copy link
Contributor

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@baijumeswani
Copy link
Contributor

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime React Native CI Pipeline Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@tianleiwu
Copy link
Contributor

/azp run Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@baijumeswani baijumeswani merged commit 1f4a352 into microsoft:main Sep 27, 2023
@jambayk jambayk deleted the jambayk/fusion-attention-bugfix branch September 28, 2023 03:08
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants