-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Add initializer to model in AttentionMask directly #17719
Bugfix: Add initializer to model in AttentionMask directly #17719
Conversation
@tianleiwu FYI |
@tianleiwu can you please trigger the required pipelines using /azp run commands? I don’t also have merge permissions for when the required checks are complete. |
/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline |
/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime React Native CI Pipeline Windows x64 QNN CI Pipeline |
Azure Pipelines successfully started running 7 pipeline(s). |
Azure Pipelines successfully started running 9 pipeline(s). |
/azp run Windows x64 QNN CI Pipeline |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Fixes a bug introduced in PR #17427 where
self.add_initializer
is called inAttentionMask
but the class doesn't have the given method.This adds the initializer directly to
self.model
as before but withraw=False
as intended in the PR above.Motivation and Context
Fixes the bug described above.
The bug was caught while running Olive tests with the latest ort-nightly builds.
https://dev.azure.com/aiinfra/PublicPackages/_build/results?buildId=360918&view=logs&j=dbbdd4d8-ffd3-515a-31fd-659375dbdff8&t=13dad60e-7187-5e88-dbc0-776ed0850a3f&l=601