Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js/web] FP16 LayerNorm, InstanceNorm, SkipLayerNorm #17630

Merged
merged 8 commits into from
Oct 18, 2023
Merged

[js/web] FP16 LayerNorm, InstanceNorm, SkipLayerNorm #17630

merged 8 commits into from
Oct 18, 2023

Conversation

dakenf
Copy link
Contributor

@dakenf dakenf commented Sep 20, 2023

Description

This PR includes fixes for Norm operations to support FP16 and also some optimizations to use vec2/vec4 if possible

@guschmue guschmue added the ep:WebNN WebNN execution provider label Sep 25, 2023
qjia7
qjia7 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question.

js/web/lib/wasm/jsep/webgpu/ops/layer-norm.ts Outdated Show resolved Hide resolved
@fs-eire
Copy link
Contributor

fs-eire commented Sep 29, 2023

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Sep 29, 2023

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@guschmue guschmue added ep:WebGPU ort-web webgpu provider and removed ep:WebNN WebNN execution provider labels Sep 29, 2023
@guschmue
Copy link
Contributor

lint is nagging.

@fs-eire
Copy link
Contributor

fs-eire commented Oct 3, 2023

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Oct 3, 2023

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@fs-eire
Copy link
Contributor

fs-eire commented Oct 7, 2023

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Oct 7, 2023

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

guschmue
guschmue previously approved these changes Oct 10, 2023
View reviewed changes
dakenf added 2 commits October 16, 2023 01:04
@dakenf
Merge branch 'upstream' into fp16-norm
53543bc 
# Conflicts:
#	js/web/lib/wasm/jsep/webgpu/ops/instance-norm.ts
#	js/web/lib/wasm/jsep/webgpu/ops/layer-norm.ts
#	js/web/lib/wasm/jsep/webgpu/ops/skip-layer-norm.ts
@dakenf
getRunData changes
542c2dd
@fs-eire
Copy link
Contributor

fs-eire commented Oct 16, 2023

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Oct 16, 2023

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@guschmue guschmue merged commit 2294710 into microsoft:main Oct 18, 2023
jchen351 pushed a commit that referenced this pull request Oct 18, 2023
@dakenf @jchen351
[js/web] FP16 LayerNorm, InstanceNorm, SkipLayerNorm (#17630)
48ab0ce 
### Description
This PR includes fixes for Norm operations to support FP16 and also some
optimizations to use vec2/vec4 if possible
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
@dakenf @kleiti
[js/web] FP16 LayerNorm, InstanceNorm, SkipLayerNorm (microsoft#17630)
3c209f3 
### Description
This PR includes fixes for Norm operations to support FP16 and also some
optimizations to use vec2/vec4 if possible
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@dakenf
[js/web] FP16 LayerNorm, InstanceNorm, SkipLayerNorm (microsoft#17630)
3a87677 
### Description
This PR includes fixes for Norm operations to support FP16 and also some
optimizations to use vec2/vec4 if possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fs-eire fs-eire fs-eire left review comments

@guschmue guschmue guschmue approved these changes

@qjia7 qjia7 qjia7 approved these changes

Assignees
No one assigned
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dakenf @fs-eire @guschmue @qjia7