Prevent GSL_SUPPRESS arguments from being modified by clang-format #17242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d between tokens, as in 'r .11', update existing usages.
|
Really really thanks! I was curious why sometimes the macro works sometimes it doesn't. I couldn't find out why. |
snnn
reviewed
Aug 22, 2023
...contrib_ops/cuda/bert/tensorrt_fused_multihead_attention/flash_attention/sharedCubinLoader.h
Outdated
Show resolved
Hide resolved
snnn
previously approved these changes
Aug 22, 2023
snnn
approved these changes
Aug 23, 2023
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
…icrosoft#17242) Prevent `GSL_SUPPRESS` arguments from being modified by clang-format and update existing usages. clang-format was changing something like `GSL_SUPPRESS(r.11)` to `GSL_SUPPRESS(r .11)`. For some compilers (e.g., clang), the `gsl::suppress` attribute takes a quoted string argument. We don't want to insert spaces there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent
GSL_SUPPRESSarguments from being modified by clang-format and update existing usages.Motivation and Context
clang-format was changing something like
GSL_SUPPRESS(r.11)toGSL_SUPPRESS(r .11).For some compilers (e.g., clang), the
gsl::suppressattribute takes a quoted string argument. We don't want to insert spaces there.https://clang.llvm.org/docs/AttributeReference.html#suppress