[JS/WebGPU] Expand operator fixes #17137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariharans29
commented
Aug 14, 2023
hariharans29
commented
Aug 14, 2023
fs-eire
previously approved these changes
Aug 14, 2023
satyajandhyala
previously approved these changes
Aug 16, 2023
satyajandhyala
approved these changes
Aug 16, 2023
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
siweic0
pushed a commit
to siweic0/onnxruntime-web
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
cacheHintforExpandis set to be a function of the input tensors' shapes. This is a problem because the shader is a function of the first input's shape and the second input's contents. Without this fix, we could be using a cachedProgramInfoincorrectly in places where we should be using a differentProgramInfo. A test is checked-in for this.Support the first input tensor being 1-D. The
const inputShape = ${input.indices(...inputShape)};returns anu32for a 1-D tensor which means that we can't be using logic likeinputShape[i]in that case as it is not anarray. A similar (but not exactly the same) issue was fixed in [js/web] JSEP Expand fix for inputs with rank < 2 #16829 but after the indices helper refactoring a similar issue was re-introduced back. A fix is proposed and a test is added for this.Motivation and Context
Fix some bugs in
ExpandWebGPU