Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js/WebGPU] Support int32 Transpose in WebGPU #16952

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Conversation

hariharans29
Copy link
Member

@hariharans29 hariharans29 commented Aug 1, 2023

Description

Support (u)int32 transpose in JSEP/WebGPU as it is required for Segment Anything Encoder per operator tracking table: #15952.

Motivation and Context

Improve WebGPU op coverage

@axinging
Copy link
Contributor

axinging commented Aug 1, 2023

Maybe you forget to add test case in js/web/test/suite-test-list.jsonc?
We have implemented transpose_int32.jsonc here:
https://github.com/xhcao/onnxruntime/blob/webgpu_transpose_int32/js/web/test/data/ops/transpose_int32.jsonc

guschmue
guschmue previously approved these changes Aug 1, 2023
js/web/lib/wasm/jsep/webgpu/ops/transpose.ts Show resolved Hide resolved
@guschmue
Copy link
Contributor

guschmue commented Aug 1, 2023

ci is failing because of test*json formatting - I think there is a fix from Yulong being merged.

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Aug 1, 2023
@hariharans29
Copy link
Member Author

Maybe you forget to add test case in js/web/test/suite-test-list.jsonc? We have implemented transpose_int32.jsonc here: https://github.com/xhcao/onnxruntime/blob/webgpu_transpose_int32/js/web/test/data/ops/transpose_int32.jsonc

Adding it as a separate file and adding that file to the WebGPU list should work fine. :) I can follow a similar approach. Also, I wasn't aware that you were already working on it as I didn't see anyone assigned to it in the op tracking list - apologies for that.

@hariharans29 hariharans29 merged commit 506ddb3 into main Aug 2, 2023
@hariharans29 hariharans29 deleted the hari/webgpu_transpose branch August 2, 2023 23:27
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants