[js/webgpu] Adding not operator #16891
Conversation
| @@ -92,6 +92,7 @@ class ONNX_OPERATOR_KERNEL_CLASS_NAME(kJsExecutionProvider, kOnnxDomain, 13, Erf | |||
| class ONNX_OPERATOR_VERSIONED_KERNEL_CLASS_NAME(kJsExecutionProvider, kOnnxDomain, 6, 12, Sigmoid); | |||
| class ONNX_OPERATOR_KERNEL_CLASS_NAME(kJsExecutionProvider, kOnnxDomain, 13, Sigmoid); | |||
|
|
|||
| class ONNX_OPERATOR_KERNEL_CLASS_NAME(kJsExecutionProvider, kOnnxDomain, 7, Not); | |||
There was a problem hiding this comment.
"Not" operator is available since opset version1 unlike Sin, Cos, etc.
There was a problem hiding this comment.
It looks like the npm test -- op not.jsonc -b=webgpu actually runs CPU kernel because it's not correctly registered.
There was a problem hiding this comment.
Anything on my size was doing it wrong, or it just something else? @fs-eire
| if (funcCall === 'not') { | ||
| expression = '!a'; | ||
| } else { | ||
| expression = `${funcCall}(a)`; | ||
| } |
There was a problem hiding this comment.
please do not modify this general function. use the funcCall param instead.
There was a problem hiding this comment.
Let me try with passing not operator as BuiltinFunctionName instead.
There was a problem hiding this comment.
no. not is not a built in function so don't use it in BuiltinFunctionName. you can use lambda like (x => `!(${x})`).
|
This change may need to wait my work-in-progress change to enable bool data type for webgpu. |
|
replaced by #17306 |
Description
Motivation and Context