[Better Engineering] Fix N802 lint errors in tests #16788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
justinchuby
changed the title
jcwchen
approved these changes
Jul 21, 2023
|
The only risk I could think of was if we were selecting tests based on their names, but having done a search on the repo this doesn't seem to be the case. |
|
I will merge this PR to reduce the possibility of future conflicts. Happy to address other concerns or revert if needed. |
justinchuby
added a commit
that referenced
this pull request
Jul 21, 2023
…and fix new lint errors" Based on #16788 Bump ruff to 0.0.278 and fix new lint errors. I added noqa to all existing RUF012 errors which requires mutable class variables to be annotated with `ClassVar`. Signed-off-by: Justin Chu <justinchumicrosoft.com> [ghstack-poisoned]
justinchuby
added a commit
that referenced
this pull request
Jul 21, 2023
… errors" Based on #16788 Bump ruff to 0.0.278 and fix new lint errors. I added noqa to all existing RUF012 errors which requires mutable class variables to be annotated with `ClassVar`. Signed-off-by: Justin Chu <justinchumicrosoft.com> [ghstack-poisoned]
jchen351
pushed a commit
that referenced
this pull request
Aug 12, 2023
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #16789 * __->__ #16788 This change fixes the N802 lint errors by renaming the test case to use snake case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This change fixes the N802 lint errors by renaming the test case to use snake case.