Add a missing header to cuda_common.h #15489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following three lines are needed before including some cutlass header files, because cutlass uses "and"/"or" keywords. Generally it should not be a problem without this header, but nvcc is not strictly compliant to C++ standard.
We didn't hit this problem because the above code exists in absl. We always include absl headers first. However, ABSL recently deleted them! abseil/abseil-cpp#1246
The cutlass dependency was introduced in #14343 , after we had abseil.