Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing header to cuda_common.h #15489

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Add a missing header to cuda_common.h #15489

merged 2 commits into from
Apr 13, 2023

Conversation

snnn
Copy link
Member

@snnn snnn commented Apr 12, 2023

Description

The following three lines are needed before including some cutlass header files, because cutlass uses "and"/"or" keywords. Generally it should not be a problem without this header, but nvcc is not strictly compliant to C++ standard.

#ifdef __cplusplus
#include <ciso646>
#endif

We didn't hit this problem because the above code exists in absl. We always include absl headers first. However, ABSL recently deleted them! abseil/abseil-cpp#1246

The cutlass dependency was introduced in #14343 , after we had abseil.

@snnn snnn requested review from edgchen1 and tianleiwu April 12, 2023 21:24
@snnn snnn mentioned this pull request Apr 12, 2023
@snnn snnn merged commit a22dc65 into main Apr 13, 2023
@snnn snnn deleted the snnn/fix_cuda_build branch April 13, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants