Specify deps in deps.txt and manifest #14530
Conversation
| @@ -318,16 +318,6 @@ | |||
| "comments": "onnx_tensorrt" | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Was this removal auto-generated?
There was a problem hiding this comment.
restored remove part manually, let's keep it.
| @@ -11,7 +11,7 @@ steps: | |||
| packageType: upack | |||
| feed: '/7424c8e4-5c62-490e-95c4-79446f31017c' | |||
| definition: '517c4f6f-5437-4392-a70d-4f15ec5be2f0' | |||
| version: 1.0.25 | |||
| version: 1.0.27 | |||
There was a problem hiding this comment.
what's the reason for this change?
There was a problem hiding this comment.
It is required by the OneNote page on deps.
The version is here.
| "commitHash": "75a84807a019bf4961faf713df9d748f0fc83b47", | ||
| "repositoryUrl": "https://github.com/triton-inference-server/server.git" | ||
| }, | ||
| "comments": "triton" |
There was a problem hiding this comment.
do we also need to mention the other repos triton client depends on?
There was a problem hiding this comment.
Right - may be we should also add the client here.
Updated. |
|
LGTM |
| "type": "git", | ||
| "git": { | ||
| "commitHash": "75a84807a019bf4961faf713df9d748f0fc83b47", | ||
| "repositoryUrl": "https://github.com/triton-inference-server/server.git" |
There was a problem hiding this comment.
The whole server is compiled into the triton client? We're not shipping the triton server.
| "type": "git", | ||
| "git": { | ||
| "commitHash": "da041154c6bac1a4aa98254a7d6819059e8ac0b0", | ||
| "repositoryUrl": "https://github.com/boostorg/boost.git" |
There was a problem hiding this comment.
same comment as server
|
|
||
| _____ | ||
|
|
||
| boostorg/boost, https://github.com/boostorg/boost |
There was a problem hiding this comment.
This is already present in this file.
Specify new deps and update cgmanifest.json. --------- Co-authored-by: Randy Shuai <[email protected]>
Specify new deps and update cgmanifest.json. --------- Co-authored-by: Randy Shuai <[email protected]>
Specify new deps and update cgmanifest.json. --------- Co-authored-by: Randy Shuai <[email protected]>
Specify new deps and update cgmanifest.json. --------- Co-authored-by: Randy Shuai <[email protected]>
Specify new deps and update cgmanifest.json.