Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Include python training apis when enable_training is enabled #14485

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

baijumeswani
Copy link
Contributor

PR #14136 inadvertently disabled packaging training apis related to the flag --enable_training_apis. As a result onnxruntime-training package since that PR was merged did not include the training apis.

This PR addresses this bug.

@baijumeswani baijumeswani added training issues related to ONNX Runtime training; typically submitted using template release:1.14 labels Jan 30, 2023
Copy link
Contributor

@askhade askhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@pengwa pengwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, our CIs can still pass?

@baijumeswani
Copy link
Contributor Author

The problem is that our packaging pipeline builds with --enable-training flag and does only simple ortmodule related testing.
The orttraining-linux-gpu-ci-pipeline does not test for training apis and so can also succeed.
The only pipeline that runs training api related code is orttraining-linux-gpu-training-apis pipeline. And that is explicitly built with --enable-training-apis.

So, none of our pipelines were able to capture this case.

@baijumeswani baijumeswani merged commit d06ad94 into main Feb 1, 2023
@baijumeswani baijumeswani deleted the baijumeswani/include-training-apis branch February 1, 2023 01:17
@faxu faxu added the triage:approved Approved for cherrypicks for release label Feb 1, 2023
@faxu faxu removed the release:1.14 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
training issues related to ONNX Runtime training; typically submitted using template triage:approved Approved for cherrypicks for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants