cpplint & Eager mode: refactor and add comments to empty_* functions, general lint cleanup in ort_aten #12238
Conversation
|
Just a couple of things to consider on the PR / commit message:
I would consider tweaking commit message - If I was just looking through commit history, I am not sure this would know what
or
Also - maybe remove boilerplate PR description for "Motivation and Context" when committing change / creating merge commit? |
msftlincoln
changed the title
msftlincoln
changed the title
| @@ -34,5 +34,10 @@ | |||
| "python.linting.pydocstyleArgs": [ | |||
| "--convention=google" | |||
| ], | |||
| "python.linting.banditEnabled": true | |||
| "python.linting.banditEnabled": true, | |||
| "cpplint.lineLength": 120, | |||
There was a problem hiding this comment.
Is there documentation for the cpplint settings? Does this apply to a particular extension?
| onnxruntime::TensorShape(tensor.sizes().vec()), | ||
| tensor.data_ptr(), | ||
| *mem_info, ort_tensor, | ||
| 0L, // offset = 0 - because tensor.data_ptr() includes the underyling offset |
There was a problem hiding this comment.
nit: should we fix up spelling here while we are tidying this file?
There was a problem hiding this comment.
In the PR description / merge commit, consider including details about why you added these specific cpplint values, and maybe what these specific filters control.
Thank you for making it easier to match the style rules applied during the CI build locally, and cleaning up the style issues to remove warnings!
Description: Minor updates to clarify and simplify implementations of empty_* eager functions.
Cleanup cpplint errors in ort_aten.cpp.
Add cpplint vscode settings.