Remove onnxruntime_util dependency on onnxruntime_framework #10512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untime.cmake ordering. Move EigenMap to core/framework/math_utils.h.
snnn
reviewed
Feb 10, 2022
There was a problem hiding this comment.
LGTM. I will approve it when all the build pass.
Besides,
- I hope our core framework does not rely on eigen much. I think eigen is EP specific.
- I made an error. Around cmake/onnxruntime_unittests.cmake line 504, I listed "onnxruntime_util" twice. if you will make more changes to this PR, please help me remove the duplicated one. Otherwise I will do it.
edgchen1
changed the title
snnn
approved these changes
Feb 10, 2022
@snnn will merge without additional changes so won't get to 2. in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a circular dependency between onnxruntime_util and onnxruntime_framework.
Remove onnxruntime_util's dependency on onnxruntime_framework.
Motivation and Context
Remove circular dependency.