Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] UTs and code clean up #10511

Merged
merged 9 commits into from
Feb 11, 2022
Merged

[ROCm] UTs and code clean up #10511

merged 9 commits into from
Feb 11, 2022

Conversation

ytaous
Copy link
Contributor

@ytaous ytaous commented Feb 10, 2022 •
edited
Loading

Description:

  • code clean up for ROCm/SoftmaxGrad
  • fix build issue caused by FastGelu/nv_bfloat162 macro
  • add UT to trigger cudnn call for FP16/BFloat16
    -- same BFloat16 UT failed for ROCm/miopen, follow the same logic on cudnn for now
  • Fix MixPrecisionScale/BiasGelu/FastGelu UTs

TODOs: (in new PR)

  • missing kernel registries (by comparing CUDA's)
  • investigate UT for ROCm/bfp16 support on reducesum
  • train example on AMD cluster

weixingzhang
weixingzhang previously approved these changes Feb 11, 2022
View reviewed changes
@ytaous ytaous changed the title [WIP] - [ROCm] UTs and code clean up [ROCm] UTs and code clean up Feb 11, 2022
@ytaous ytaous merged commit 4e2a974 into master Feb 11, 2022
@ytaous ytaous deleted the ettao/bf16-6 branch February 11, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@centwang centwang centwang approved these changes

@weixingzhang weixingzhang Awaiting requested review from weixingzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ytaous @centwang @weixingzhang