Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js/react_native] Create ONNX Runtime React Native pipeline #10474

Merged
merged 110 commits into from
Feb 10, 2022
Merged

[js/react_native] Create ONNX Runtime React Native pipeline #10474

merged 110 commits into from
Feb 10, 2022

Conversation

hanbitmyths
Copy link
Contributor

@hanbitmyths hanbitmyths commented Feb 5, 2022 •
edited
Loading

This PR adds onnxruntime-react-native pipeline with e2e testing. There are lots of changes in this PR, but it's mostly because an example directory name is changed to e2e. Here the list of important changes.

  • README.md explains how to run Android and iOS e2e tests and make npm package
  • Android react native bridge library doesn't require to specify the version explicitly in gradle.properties. It picks up ONNX Runtime aar package in android/libs directory if exists or it downloads a published version
  • Use the same gradle version 6.8.3 as mobile pipeline
  • Use espresso test framework for Android e2e test
  • Add both Android and iOS UI test to check if inference runs properly
  • Remove direct dependency on bridge library from e2e tests. Instead, create and install onnxruntime-common and onnxruntime-react-native npm packages, then start to run tests
  • Add mac-react-native-ci-pipeline.yml to build, test, and publish onnxruntime-react-native npm package
  • android-java-api-aar.yml is changed to get a pool name as a parameter
  • pack-npm-packages.ps1 is changed to publish a react native package and to be able to run at cross-platform

The latest result of a pipeline can be found at here.

@hanbitmyths
Pipeline for ONNX Runtime react native
1b92749
@hanbitmyths
Fix a test failure
4e2d77b
@hanbitmyths
test with custom built binaries
7b6d3ac
@hanbitmyths
add onnxruntime-common package back
7445506
@hanbitmyths
don't bob build when bootstrap
1a2a9eb
@hanbitmyths
revise Android test
181283c
@hanbitmyths
rename example to e2e
1390a14
@hanbitmyths
Merge branch 'master' of https://github.com/microsoft/onnxruntime
6fb7107
@hanbitmyths
Merge branch 'master' into sunghcho/react_native_pipeline
3d51f4a
@hanbitmyths
remove onnxruntime packages from package.json
e7d844a
@hanbitmyths
remove release-it package
7764946
@hanbitmyths
upgrade gradle version to the same as CI
0a5bb4b
@hanbitmyths
add a pipeline for react native
8fc11bd
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
2467a73
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
4586674
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
ff9ed66
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
4200749
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
f474673
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
f9c1a85
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
d3f99e0
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
883849e
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
a7097b4
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
ffcf21b
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
f5d8581
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
194ffd6
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
85bd2eb
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
d077694
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
c60c578
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
38a4ca9
@hanbitmyths
Update mac-react-native-ci-pipeline.yml for Azure Pipelines
e9e5b2c
guoyu-wang
guoyu-wang reviewed Feb 7, 2022
View reviewed changes
js/README.md Outdated Show resolved Hide resolved
guoyu-wang
guoyu-wang previously approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@guoyu-wang guoyu-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Android/iOS and pipeline

guoyu-wang
guoyu-wang previously approved these changes Feb 8, 2022
View reviewed changes
fs-eire
fs-eire previously approved these changes Feb 10, 2022
View reviewed changes
tools/ci_build/github/js/pack-npm-packages.ps1 Outdated Show resolved Hide resolved
@hanbitmyths hanbitmyths dismissed stale reviews from fs-eire and guoyu-wang via 1ab014d February 10, 2022 01:05
@hanbitmyths hanbitmyths merged commit dd33ce0 into master Feb 10, 2022
@hanbitmyths hanbitmyths deleted the sunghcho/react_native_pipeline branch February 10, 2022 05:37
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@hanbitmyths
[js/react_native] Create ONNX Runtime React Native pipeline (microsof…
4906904 
…t#10474)

* Pipeline for ONNX Runtime react native

* Fix a test failure

* test with custom built binaries

* add onnxruntime-common package back

* don't bob build when bootstrap

* revise Android test

* rename example to e2e

* remove onnxruntime packages from package.json

* remove release-it package

* upgrade gradle version to the same as CI

* add a pipeline for react native

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* android and ios mobile build for react native e2e

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* use android aar package template

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* use android aar package template

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* publish ios test results

* add e2e tests and publish a npm package

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* remove aar from npm package

* wait for view displayed

* change a waiting logic

* increase wait time for app launching

* give more time to launch an app

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* disable metro server on testing

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* test ios simulator launching

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* fix iOS e2e test

* use a publishing version of npm packages

* make pretty

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* make only one onnxruntime-common package after packaging

* make a powershell script of packaging universal

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Add a warning for file changes during a test

* clean up

* fix lint errors

* fix js npm packaging

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* Update mac-react-native-ci-pipeline.yml for Azure Pipelines

* resolve comments

* fix a typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoyu-wang guoyu-wang guoyu-wang approved these changes

@fs-eire fs-eire fs-eire left review comments

@jingyanwangms jingyanwangms Awaiting requested review from jingyanwangms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanbitmyths @fs-eire @guoyu-wang