Add logic to NNAPI EP to exclude pre-processing involving dynamic shapes when partitioning #10452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 31, 2022 17:41
YUNQIUGUO
changed the title
guoyu-wang
reviewed
Feb 2, 2022
guoyu-wang
reviewed
Feb 2, 2022
| ASSERT_STATUS_OK(session_object.RegisterExecutionProvider(std::make_unique<NnapiExecutionProvider>(0))); | ||
| ASSERT_STATUS_OK(session_object.Load(model_file_name)); | ||
| ASSERT_STATUS_OK(session_object.Initialize()); | ||
| ASSERT_GT(CountAssignedNodes(session_object.GetGraph(), kNnapiExecutionProvider), 0) |
There was a problem hiding this comment.
For this particular graph, the number of assigned nodes (Add only) should be 1, can use ASSERT_EQ instead of ASSERT_GT
guoyu-wang
reviewed
Feb 2, 2022
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| GenerateModel('nnapi_dynamic_graph_input_test.onnx') |
There was a problem hiding this comment.
This model can be applied to CoreML as well, can change the name to something like dynamic_graph_input_test.onnx or `ep_dynamic_graph_input_test.onnx'?
guoyu-wang
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
Add logic to EPs to exclude pre-processing involving dynamic shapes when partitioning
Motivation and Context
check if it's just the initial part of the graph using dynamic input that becomes fixed after a Resize so that the new insertion of pre-processing logic does not prevent NNAPI being used.