Reduce test time for TensorRT EP CI #10408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
reviewed
Jan 27, 2022
| @@ -682,13 +682,19 @@ if (onnxruntime_BUILD_WEBASSEMBLY) | |||
| endif() | |||
| endif() | |||
|
|
|||
| set(test_all_args) | |||
| if (onnxruntime_USE_TENSORRT) | |||
| list(APPEND test_all_args "--gtest_filter=-*cpu__*:*cuda__*" ) | |||
There was a problem hiding this comment.
comment on what we want to exclude here would be helpful.
There was a problem hiding this comment.
comments are added here.
There was a problem hiding this comment.
I don't know where the "cpu__" and "cuda__" in the test names come from - I didn't see them in the code. Explaining that would be helpful.
There was a problem hiding this comment.
Made the comment more clear.
# The test names of model tests were using sequential number in the past.
# This PR https://github.com/microsoft/onnxruntime/pull/10220 (Please see ExpandModelName function in model_tests.cc for more details)
# made test name contain the "ep" and "model path" information, so we can easily filter the tests using cuda ep or other ep with *cpu__* or *xxx__*.
jywu-msft
reviewed
Jan 30, 2022
| @@ -1168,8 +1175,12 @@ void OpTester::Run( | |||
| cur_provider = "not set"; | |||
| } | |||
|
|
|||
| #ifdef USE_TENSORRT | |||
| ORT_UNUSED_PARAMETER(has_run); | |||
There was a problem hiding this comment.
add a comment here to explain this case here.
we are allowing tests to be run with only TensorRT EP, but TensorRT EP may not support all tests and may be in excluded providers list.
jywu-msft
previously approved these changes
Jan 30, 2022
jywu-msft
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating to TRT 8.2, some tests require longer time to finish because new algorithms are added in TRT.
Following three modifications which are made specific to TRT EP CI can help reduce CI time by ~25 min on both Windows/Linux: