Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dll version of Microsoft.ML.OnnxRuntime.dll is 0.0.0.0 #21475

Closed
sportbilly21 opened this issue Jul 24, 2024 · 7 comments
Closed

Dll version of Microsoft.ML.OnnxRuntime.dll is 0.0.0.0 #21475

sportbilly21 opened this issue Jul 24, 2024 · 7 comments
Labels
api:CSharp issues related to the C# API build build issues; typically submitted using template .NET Pull requests that update .net code platform:windows issues related to the Windows platform

Comments

@sportbilly21
Copy link

Describe the issue

System Information (please complete the following information):

OS & Version: either Windows 10 or 11
ML.NET Version: versions 1.7 and 3.0
Microsoft.ML.OnnxRuntime.Gpu version 1.15.1 and 1.18.1
.NET Version: .netframework 4.7
Describe the bug
After building the solution the version of the Microsoft.ML.OnnxRuntime.dll is 0.0.0.0
This is not causing any issues if you are running the application through the Visual Studio.
But we create an installer with Wix for installation in production PC
When you install the software in Windows, the OS and wix due to the version of the dll being zero, they think the dll is corrupted and the installation cannot continue as the installer tries to recover the corrupted dll.

We have a work around by changing the version of the above dll but from my understanding dlls should not have 0 as a version

Screenshot 2024-04-19 084244

Urgency

No response

Target platform

Windows 10

Build script

The Dll version has an issue

Error / output

Screenshot 2024-04-19 084244

Visual Studio Version

2019 and 2022

GCC / Compiler Version

No response

@sportbilly21 sportbilly21 added the build build issues; typically submitted using template label Jul 24, 2024
@github-actions github-actions bot added the platform:windows issues related to the Windows platform label Jul 24, 2024
@skottmckay skottmckay added the api:CSharp issues related to the C# API label Jul 25, 2024
@skottmckay
Copy link
Contributor

There is a PackageVersion property that can be set but the packaging pipeline isn't passing through the ORT version currently. We'll look at updating it so that the version is set for official release builds.

@sportbilly21
Copy link
Author

Many thanks for your quick response. Please let us know when this is fixed so I can update also our solution

@sophies927 sophies927 added the .NET Pull requests that update .net code label Jul 25, 2024
skottmckay added a commit that referenced this issue Jul 27, 2024
### Description
<!-- Describe your changes. -->
Set version and other info in the Microsoft.ML.OnnxRuntime C# dll by
setting GenerateAssemblyInfo to true and passing in ORT version in the
CI.

Minor re-org of the order of properties so related things are grouped a
little better.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
#21475
@sportbilly21
Copy link
Author

sportbilly21 commented Jul 31, 2024

Hi many thanks for trying to resolve this so quickly, I have tried the lastest Nuget package 1.18.1 either the GPU, which I am using in the app, and the CPU one, but the version is still 0.0.0.0
image

Can you please let me know if this fix is incluced in the 1.18.1?
Many thanks

@skottmckay
Copy link
Contributor

Change will be in the 1.19 release

@skottmckay
Copy link
Contributor

The nightly packages have the update if you want to verify: https://aiinfra.visualstudio.com/PublicPackages/_artifacts/feed/ORT-Nightly

@sportbilly21
Copy link
Author

Thank you very much for the update.

@sportbilly21
Copy link
Author

sportbilly21 commented Nov 11, 2024

Hi many thanks for fixing this, it is working as expected
Image

But now the nuget package Microsoft.ML.OnnxTransformer which I know it is not your responsibility still asks the 0.0.0.0 version.Get runtime error for that packages
Could not load file or assembly 'Microsoft.ML.OnnxRuntime, Version=0.0.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:CSharp issues related to the C# API build build issues; typically submitted using template .NET Pull requests that update .net code platform:windows issues related to the Windows platform
Projects
None yet
Development

No branches or pull requests

3 participants