Multi-Lora support #34558
Triggered via pull request
September 28, 2024 23:32
Status
Success
Total duration
14m 12s
Artifacts
–
lint.yml
on: pull_request
Optional Lint
31s
Python format
3m 29s
Optional Lint C++
14m 3s
Lint JavaScript
27s
Annotations
1 error and 16 warnings
Optional Lint C++
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
Python format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Python format
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Optional Lint C++:
include/onnxruntime/core/session/onnxruntime_cxx_api.h#L745
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
include/onnxruntime/core/session/onnxruntime_cxx_api.h:745: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Optional Lint C++:
onnxruntime/core/session/lora_adapters.cc#L7
[cpplint] reported by reviewdog 🐶
Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
Raw Output:
onnxruntime/core/session/lora_adapters.cc:7: Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
|
Optional Lint C++:
onnxruntime/core/session/lora_adapters.cc#L102
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
onnxruntime/core/session/lora_adapters.cc:102: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Optional Lint C++:
onnxruntime/core/session/lora_adapters.cc#L161
[cpplint] reported by reviewdog 🐶
Add #include <memory> for make_unique<> [build/include_what_you_use] [4]
Raw Output:
onnxruntime/core/session/lora_adapters.cc:161: Add #include <memory> for make_unique<> [build/include_what_you_use] [4]
|
Optional Lint C++:
onnxruntime/core/session/lora_adapters.cc#L166
[cpplint] reported by reviewdog 🐶
Add #include <utility> for move [build/include_what_you_use] [4]
Raw Output:
onnxruntime/core/session/lora_adapters.cc:166: Add #include <utility> for move [build/include_what_you_use] [4]
|
Optional Lint C++:
onnxruntime/core/session/lora_adapters.h#L14
[cpplint] reported by reviewdog 🐶
Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
Raw Output:
onnxruntime/core/session/lora_adapters.h:14: Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
|
Optional Lint C++:
onnxruntime/core/session/lora_adapters.h#L15
[cpplint] reported by reviewdog 🐶
Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
Raw Output:
onnxruntime/core/session/lora_adapters.h:15: Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
|
Optional Lint C++:
onnxruntime/core/session/lora_adapters.h#L16
[cpplint] reported by reviewdog 🐶
Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
Raw Output:
onnxruntime/core/session/lora_adapters.h:16: Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
|
Optional Lint C++:
onnxruntime/core/session/lora_adapters.h#L17
[cpplint] reported by reviewdog 🐶
Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
Raw Output:
onnxruntime/core/session/lora_adapters.h:17: Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
|
Optional Lint C++:
onnxruntime/core/session/lora_adapters.h#L18
[cpplint] reported by reviewdog 🐶
Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
Raw Output:
onnxruntime/core/session/lora_adapters.h:18: Found C++ system header after other header. Should be: lora_adapters.h, c system, c++ system, other. [build/include_order] [4]
|