Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the framework bundle identifier to a valid bundle ID #829

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ronyfadel
Copy link
Contributor

@ronyfadel ronyfadel commented Oct 21, 2024

Ref: #825

"com.microsoft.onnxruntime_extensions" is not a valid identifier. Update it to "com.microsoft.onnxruntime-extensions".

cc @wenbingl @edgchen1

Ref: microsoft#825

"com.microsoft.onnxruntime_extensions" is not a valid identifier. Update it to "com.microsoft.onnxruntime-extensions"
@wenbingl
Copy link
Member

/azp run onnxruntime-extensions.CI

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@wenbingl wenbingl merged commit 8de0d6c into microsoft:main Oct 21, 2024
2 checks passed
@wenbingl
Copy link
Member

It looks like a branch named 'main' cannot be triggered for CI pipeline. But given the change and it was approved, I forcedly merged the PR, which run pipelines on main branch automatically.

apsonawane pushed a commit that referenced this pull request Oct 28, 2024
Ref: #825

"com.microsoft.onnxruntime_extensions" is not a valid identifier. Update it to "com.microsoft.onnxruntime-extensions"
apsonawane added a commit that referenced this pull request Oct 28, 2024
Ref: #825

"com.microsoft.onnxruntime_extensions" is not a valid identifier. Update it to "com.microsoft.onnxruntime-extensions"

Co-authored-by: Rony Fadel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants