Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(tutorials): exporting yolo world model #803

Merged

Conversation

legendof-selda
Copy link
Contributor

This allows us to export yolo world onnx model which can be later used in mobile inference.

This allows us to export yolo world onnx model which can be later used in mobile inference.
@legendof-selda legendof-selda requested a review from a team as a code owner September 5, 2024 22:38
@legendof-selda
Copy link
Contributor Author

@microsoft-github-policy-service agree

Comment on lines 308 to 313
parser.add_argument(
"--classes",
type=Path,
default="classes.json",
help="JSON file containing list of classes that will be set as yolo world prompt.",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should a user get this file from in order to run the script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In yolo world you specify prompts to the model. So, it's just a list of text/classes that you will prompt the model for zero-shot detection. So, it's user specified. The user has to create the list of prompts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally a tutorial is self-contained with default inputs that allow running it end-to-end. We want it to make it as simple as possible for the user to see it working.

Is there an example classes.json that could be added that works with the default --test_image value of data/stormtroopers.jpg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add something. Should I create a file and commit it or have user pass in a list of values as classes and we can set default example classes for the argument?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have provided default values for classes as requested. Please review @skottmckay

@natke natke self-requested a review October 3, 2024 03:03
@skottmckay
Copy link
Contributor

/azp run onnxruntime-extensions.CI

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@skottmckay skottmckay merged commit f47bed4 into microsoft:main Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants