Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ONNX model generation considers opset version #682

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ensure ONNX model generation considers opset version #682

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b38779
Ensure ONNX model generation considers opset version
kazssym Mar 26, 2024
3e6e606
Merge branch 'microsoft:main' into feature/cvt-model-opset
kazssym Mar 27, 2024
3118a44
Merge branch 'main' into feature/cvt-model-opset
wenbingl Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions onnxruntime_extensions/cvt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def gen_processing_models(processor: Union[str, object],
**pre_kwargs) if pre_kwargs is not None else None
post_g = _converter.post_processing(
**post_kwargs) if post_kwargs is not None else None
return make_onnx_model(pre_g) if pre_g else None, \
make_onnx_model(post_g) if post_g else None
return make_onnx_model(pre_g, opset_version=opset) if pre_g else None, \
make_onnx_model(post_g, opset_version=opset) if post_g else None
Copy link
Member

@wenbingl wenbingl Mar 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like it also need some fixing for the case of opset==None, check CI pipeline result for more details. Would you like to do that, or wait for my help?

else:
raise ValueError(f"Unsupported processor/tokenizer: {cls_name}")
Loading