support vc runtime static linkage #472
Conversation
|
|
||
| steps: | ||
| - script: | | ||
| call .\build.bat -DOCOS_ENABLE_CTEST=ON -DCMAKE_MSVC_RUNTIME_LIBRARY="MultiThreaded$<$<CONFIG:Debug>:Debug>" |
There was a problem hiding this comment.
the argument string seems not to be easily used, any better idea?
There was a problem hiding this comment.
that could be a solution, but I noticed what protobuf did the same thing actually brought us some trouble to add some extra code to switch the flag back and forth, especially when ort-extensions was used as cmake sub-directory for another project.
DCMAKE_MSVC_RUNTIME_LIBRARY is documented feature from cmake and it's kind of a standard that we should follow.
There was a problem hiding this comment.
we could perhaps add a magic string to replace "MultiThreaded$<$CONFIG:Debug:Debug>" so it is simple for the user when passing the parameter for DCMAKE_MSVC_RUNTIME_LIBRARY to build.bat - and then we can parse it in the YAML file.
|
Merge this fixing firstly, and any further improvement are welcomed. |
No description provided.