Update auto_mixed_precision_model_path.py #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaowuhu <[email protected]> Improve some logic to not let user confuse. 1) both rtol and valudate_func could be None, then we will use default value. 2) use atol to do validation if user pass it in.
fatcat-z
reviewed
Jun 10, 2022
| @@ -39,6 +39,9 @@ def validate(res1, res2): | |||
| 1. keep_io_types=True, so the test_data can be used for both fp32 and fp16 models during the convertion. | |||
| 2. about the 'provider', when you want to inference on CPU machine, you must set it to ['CPUExecutionProvider'], | |||
| when you want to do inference on GPU machine, set to ['CUDAExecutionProvider']. | |||
| 3. the default value of rtol will be 1e-3 if it is None. | |||
There was a problem hiding this comment.
Just realized all these 5 notes are explaining the parameters of auto_convert_mixed_precision_model_path() function. Could we move them into the comments of this function, so users know its usage specifically? Just like another function convert_float_to_float16.
In addition, we can add comments for other parameters of this function as well.
Signed-off-by: xiaowuhu <[email protected]> refine the comment for this function, especially the parameters description.
Signed-off-by: xiaowuhu <[email protected]> fix the flake8 check errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaowuhu [email protected]
Improve some logic to not let user confuse.