Add InstanceNormalization op to DEFAULT_OP_BLOCK_LIST #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yetingqiaqia
approved these changes
Sep 10, 2021
BowenBao
pushed a commit
that referenced
this pull request
Dec 8, 2021
This PR is to remove InstanceNormalization op from DEFAULT_OP_BLOCK_LIST. The background is: - 3 months ago, I found InstanceNormalization was unable to work on fp16. It would generate below error: ``` File "/usr/local/lib/python3.6/dist-packages/onnxruntime/capi/onnxruntime_inference_collection.py", line 124, in run return self._sess.run(output_names, input_feed, run_options) onnxruntime.capi.onnxruntime_pybind11_state.Fail: [ONNXRuntimeError] : 1 : FAIL : Non-zero status code returned while running InstanceNormalization node. Name:'InstanceNormalization_31' Status Message: CUDNN error executing cudnnBatchNormalizationForwardTraining( CudnnHandle(), CUDNN_BATCHNORM_SPATIAL, &one, &zero, data_desc, x_data, data_desc, y_data, stats_desc, unused_scale.get(), unused_bias.get(), 1.0f, mean.get(), variance.get(), CUDNN_BN_MIN_EPSILON, nullptr, nullptr) ``` And, @TomWildenhain-Microsoft helped create this PR to block InstanceNormalization to convert fp16: #197 - Meanwhile, I also asked ORT team's help to investigate and fix InstanceNormalization op issue on fp16. The fix was done recently (Nov. 29, 2021) by @hariharans29 in this PR: microsoft/onnxruntime#9879 So, InstanceNormalization is no needed to be blocked any more. And this PR is to remove InstanceNormalization op from DEFAULT_OP_BLOCK_LIST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.