Tom/onnx2pyverify #165
Merged
Tom/onnx2pyverify #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWildenhain-Microsoft
force-pushed
the
tom/onnx2pyverify
branch
from
4a1d4aa to
ace64c7
Compare
TomWildenhain-Microsoft
force-pushed
the
tom/onnx2pyverify
branch
from
ace64c7 to
a3f2cdd
Compare
yetingqiaqia
approved these changes
Jan 7, 2021
|
|
||
| model_trace = convert_model(model) | ||
| model_trace = convert_field(model) | ||
| code = "from onnx import helper, numpy_helper, TensorProto" | ||
| if TracingObject.get_cnt(make_external_tensor_traced): |
There was a problem hiding this comment.
Looks great! Suggest to add one more comment in the code:
"""
Running <out_path+".py"> file to recreate the original onnx model.
Example usage:
python <out_path+".py"> out_model_path.onnx
"""
wenbingl
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bugs in large model support, added verification code for debugging